Re: [PATCH v3 5/6] gpio: max77620: Use irqchip template

From: Laxman Dewangan
Date: Thu Jul 09 2020 - 11:03:40 EST




On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote:
External email: Use caution opening links or attachments


This change addresses one of the GPIO-core TODOs for the MAX77620 driver
which requires modern drivers to use the irqchip template. Instead of
using the GPIO's irqchip-helpers for creating the IRQ domain, the
gpio_irq_chip structure is now filled by the driver itself and then
gpiochip_add_data() takes care of instantiating the IRQ domain for us.

Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>



Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>