Re: [PATCH bpf] selftests: bpf: fix detach from sockmap tests

From: Daniel Borkmann
Date: Thu Jul 09 2020 - 17:43:39 EST


On 7/9/20 1:51 PM, Lorenz Bauer wrote:
Fix sockmap tests which rely on old bpf_prog_dispatch behaviour.
In the first case, the tests check that detaching without giving
a program succeeds. Since these are not the desired semantics,
invert the condition. In the second case, the clean up code doesn't
supply the necessary program fds.

Reported-by: Martin KaFai Lau <kafai@xxxxxx>
Signed-off-by: Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
Fixes: bb0de3131f4c ("bpf: sockmap: Require attach_bpf_fd when detaching a program")

Applied, thanks!