Re: [PATCH 2/5] power: supply: core: add wireless charger adapter type property

[Greg KH]

On Fri, Jul 10, 2020 at 04:48:38PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> 
> Reports what type of wireless adapter connection is
> currently active forthe supply.
> for example it can show if ADAPTER_PD capable source is attached.
> 
> Signed-off-by: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 13 +++++++++++++
>  drivers/power/supply/power_supply_sysfs.c   |  1 +
>  include/linux/power_supply.h                |  1 +
>  3 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 0d9d6b46e239..2099cf194a89 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -718,3 +718,16 @@ Contact:	Fei Jiang <jiangfei1@xxxxxxxxxx>
>  		Access: Read-Only
>  		Valid values: "QUICK_CHARGE_NORMAL", "QUICK_CHARGE_FAST", "QUICK_CHARGE_FLASH",
>  		"QUICK_CHARGE_TURBE", "QUICK_CHARGE_SUPER".
> +
> +===== Wireless Charger Properties =====
> +What:		/sys/class/power_supply/<supply_name>/tx_adapter
> +Date:		Jul 2020
> +Contact:	Fei Jiang <jiangfei1@xxxxxxxxxx>
> +Description:
> +		Reports what type of wireless adapter connection is currently active for
> +		the supply, for example it can show if ADAPTER_PD capable source
> +		is attached.
> +
> +		Access: Read-Only
> +		Valid values: "ADAPTER_NONE", "ADAPTER_SDP", "ADAPTER_DCP", "ADAPTER_CDP",
> +		"ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.

Why are these strings not in the patch as well?

> \ No newline at end of file
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index f95574c41898..c864a14829ec 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -207,6 +207,7 @@ static struct power_supply_attr power_supply_attrs[] = {
>  	POWER_SUPPLY_ATTR(MANUFACTURER),
>  	POWER_SUPPLY_ATTR(SERIAL_NUMBER),
>  	POWER_SUPPLY_ATTR(quick_charge_type),
> +	POWER_SUPPLY_ATTR(tx_adapter),

upper case?

thanks,

greg k-h