Re: [PATCH 4/5] power: supply: core: property to control reverse charge

[Greg KH]

On Fri, Jul 10, 2020 at 04:48:40PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> 
> Interface to control wireless reverse charge.
> Supply reverse charge function when enabled.
> 
> Signed-off-by: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 13 ++++++++++++-
>  drivers/power/supply/power_supply_sysfs.c   |  1 +
>  include/linux/power_supply.h                |  1 +
>  3 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 1f42aa0c071e..1f489a250c19 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -737,4 +737,15 @@ Date:		Jul 2020
>  Contact:	Fei Jiang <jiangfei1@xxxxxxxxxx>
>  Description:
>  		Reports wireless signal strength.
> -		The value show degree of coupling.
> \ No newline at end of file
> +		The value show degree of coupling.
> +What:		/sys/class/power_supply/<supply_name>/reverse_chg_mode
> +Date:		Jul 2020
> +Contact:	Fei Jiang <jiangfei1@xxxxxxxxxx>
> +Description:
> +		The property supply interface to control wireless
> +		reverse charge mode.
> +
> +		Valid values:
> +		- 1: enabled
> +		- 0: disabled
> +
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 42fbe1b68255..4be762abba89 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -209,6 +209,7 @@ static struct power_supply_attr power_supply_attrs[] = {
>  	POWER_SUPPLY_ATTR(quick_charge_type),
>  	POWER_SUPPLY_ATTR(tx_adapter),
>  	POWER_SUPPLY_ATTR(signal_strength),
> +	POWER_SUPPLY_ATTR(reverse_chg_mode),

Again, uppercase for all of these?

thanks,

greg k-h