Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

From: Jakub Kicinski
Date: Fri Jul 10 2020 - 11:51:00 EST


On Fri, 10 Jul 2020 16:51:50 +0800 Zhi Li wrote:
> Add gmac platform data to support LS7A bridge chip.
>
> Co-developed-by: Hongbin Li <lihongbin@xxxxxxxxxxx>
> Signed-off-by: Hongbin Li <lihongbin@xxxxxxxxxxx>
> Signed-off-by: Zhi Li <lizhi01@xxxxxxxxxxx>

This appears to not build with allmodconfig:

../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:22:62: note: expected âstruct plat_stmmacenet_data *â but argument is of type âstruct plat_stmmacenent_data *â
22 | static void common_default_data(struct plat_stmmacenet_data *plat)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:145:6: error: invalid use of undefined type âstruct plat_stmmacenent_dataâ
145 | plat->bus_id = pci_dev_id(pdev);
| ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:146:6: error: invalid use of undefined type âstruct plat_stmmacenent_dataâ
146 | plat->phy_addr = 0;
| ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:147:6: error: invalid use of undefined type âstruct plat_stmmacenent_dataâ
147 | plat->interface = PHY_INTERFACE_MODE_GMII;
| ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:149:6: error: invalid use of undefined type âstruct plat_stmmacenent_dataâ
149 | plat->dma_cfg->pbl = 32;
| ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:150:6: error: invalid use of undefined type âstruct plat_stmmacenent_dataâ
150 | plat->dma_cfg->pblx8 = true;
| ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: At top level:
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:156:11: error: initialization of âint (*)(struct pci_dev *, struct plat_stmmacenet_data *)â from incompatible pointer type âint (*)(struct pci_dev *, struct plat_stmmacenent_data *)â [-Werror=incompatible-pointer-types]
156 | .setup = loongson_default_data;
| ^~~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:156:11: note: (near initialization for âloongson_pci_info.setupâ)
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:156:32: error: expected â}â before â;â token
156 | .setup = loongson_default_data;
| ^
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:155:51: note: to match this â{â
155 | static struct stmmac_pci_info loongson_pci_info = {
| ^
cc1: some warnings being treated as errors
make[6]: *** [drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o] Error 1
make[5]: *** [drivers/net/ethernet/stmicro/stmmac] Error 2
make[4]: *** [drivers/net/ethernet/stmicro] Error 2
make[3]: *** [drivers/net/ethernet] Error 2
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [__sub-make] Error 2