Re: [PATCH] drm/vkms: change the max cursor width/height

From: Rodrigo Siqueira
Date: Sun Jul 12 2020 - 18:05:58 EST


Hi Melissa,

First of all, thanks a lot for your patch! This is a nice change since
it increases the code coverage.

Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx>

On 07/10, Melissa Wen wrote:
> This change expands the coverage for the IGT kms_cursor_crc test, where
> the size varies between 64 and 512 for a square cursor. With this, in
> addition to the cursor 64x64, this patch enables the test of cursors with
> sizes: 128x128, 256x256, and 512x512.
>
> Signed-off-by: Melissa Wen <melissa.srw@xxxxxxxxx>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 1e8b2169d834..57a8a397d5e8 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> dev->mode_config.min_height = YRES_MIN;
> dev->mode_config.max_width = XRES_MAX;
> dev->mode_config.max_height = YRES_MAX;
> + dev->mode_config.cursor_width = 512;
> + dev->mode_config.cursor_height = 512;
> dev->mode_config.preferred_depth = 24;
> dev->mode_config.helper_private = &vkms_mode_config_helpers;
>
> --
> 2.27.0
>

--
Rodrigo Siqueira
https://siqueira.tech

Attachment: signature.asc
Description: PGP signature