Re: [PATCH v2 00/11] Fix PM hibernation in Xen guests

[Boris Ostrovsky]

On 7/15/20 3:49 PM, Anchal Agarwal wrote:
> On Mon, Jul 13, 2020 at 03:43:33PM -0400, Boris Ostrovsky wrote:
>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>>
>>
>>
>> On 7/10/20 2:17 PM, Agarwal, Anchal wrote:
>>> Gentle ping on this series.
>>
>> Have you tested save/restore?
>>
> No, not with the last few series. But a good point, I will test that and get
> back to you. Do you see anything specific in the series that suggests otherwise?


root@ovs104> xl save pvh saved
Saving to saved new xl format (info 0x3/0x0/1699)
xc: info: Saving domain 3, type x86 HVM
xc: Frames: 1044480/1044480Â 100%
xc: End of stream: 0/0ÂÂÂ 0%
root@ovs104> xl restore saved
Loading new save file saved (new xl fmt info 0x3/0x0/1699)
ÂSavefile contains xl domain config in JSON format
Parsing config from <saved>
xc: info: Found x86 HVM domain from Xen 4.13
xc: info: Restoring domain
xc: info: Restore successful
xc: info: XenStore: mfn 0xfeffc, dom 0, evt 1
xc: info: Console: mfn 0xfefff, dom 0, evt 2
root@ovs104> xl console pvh
[Â 139.943872] ------------[ cut here ]------------
[Â 139.943872] kernel BUG at arch/x86/xen/enlighten.c:205!
[Â 139.943872] invalid opcode: 0000 [#1] SMP PTI
[Â 139.943872] CPU: 0 PID: 11 Comm: migration/0 Not tainted 5.8.0-rc5 #26
[Â 139.943872] RIP: 0010:xen_vcpu_setup+0x16d/0x180
[Â 139.943872] Code: 4a 8b 14 f5 40 c9 1b 82 48 89 d8 48 89 2c 02 8b 05
a4 d4 40 01 85 c0 0f 85 15 ff ff ff 4a 8b 04 f5 40 c9 1b 82 e9 f4 fe ff
ff <0f> 0b b8 ed ff ff ff e9 14 ff ff ff e8 12 4f 86 00 66 90 66 66 66
[Â 139.943872] RSP: 0018:ffffc9000006bdb0 EFLAGS: 00010046
[Â 139.943872] RAX: 0000000000000000 RBX: ffffc9000014fe00 RCX:
0000000000000000
[Â 139.943872] RDX: ffff88803fc00000 RSI: 0000000000016128 RDI:
0000000000000000
[Â 139.943872] RBP: 0000000000000000 R08: 0000000000000000 R09:
0000000000000000
[Â 139.943872] R10: ffffffff826174a0 R11: ffffc9000006bcb4 R12:
0000000000016120
[Â 139.943872] R13: 0000000000016120 R14: 0000000000016128 R15:
0000000000000000
[Â 139.943872] FS:Â 0000000000000000(0000) GS:ffff88803fc00000(0000)
knlGS:0000000000000000
[Â 139.943872] CS:Â 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[Â 139.943872] CR2: 00007f704be8b000 CR3: 000000003901a004 CR4:
00000000000606f0
[Â 139.943872] Call Trace:
[Â 139.943872]Â ? __kmalloc+0x167/0x260
[Â 139.943872]Â ? xen_manage_runstate_time+0x14a/0x170
[Â 139.943872]Â xen_vcpu_restore+0x134/0x170
[Â 139.943872]Â xen_hvm_post_suspend+0x1d/0x30
[Â 139.943872]Â xen_arch_post_suspend+0x13/0x30
[Â 139.943872]Â xen_suspend+0x87/0x190
[Â 139.943872]Â multi_cpu_stop+0x6d/0x110
[Â 139.943872]Â ? stop_machine_yield+0x10/0x10
[Â 139.943872]Â cpu_stopper_thread+0x47/0x100
[Â 139.943872]Â smpboot_thread_fn+0xc5/0x160
[Â 139.943872]Â ? sort_range+0x20/0x20
[Â 139.943872]Â kthread+0xfe/0x140
[Â 139.943872]Â ? kthread_park+0x90/0x90
[Â 139.943872]Â ret_from_fork+0x22/0x30
[Â 139.943872] Modules linked in:
[Â 139.943872] ---[ end trace 74716859a6b4f0a8 ]---
[Â 139.943872] RIP: 0010:xen_vcpu_setup+0x16d/0x180
[Â 139.943872] Code: 4a 8b 14 f5 40 c9 1b 82 48 89 d8 48 89 2c 02 8b 05
a4 d4 40 01 85 c0 0f 85 15 ff ff ff 4a 8b 04 f5 40 c9 1b 82 e9 f4 fe ff
ff <0f> 0b b8 ed ff ff ff e9 14 ff ff ff e8 12 4f 86 00 66 90 66 66 66
[Â 139.943872] RSP: 0018:ffffc9000006bdb0 EFLAGS: 00010046
[Â 139.943872] RAX: 0000000000000000 RBX: ffffc9000014fe00 RCX:
0000000000000000
[Â 139.943872] RDX: ffff88803fc00000 RSI: 0000000000016128 RDI:
0000000000000000
[Â 139.943872] RBP: 0000000000000000 R08: 0000000000000000 R09:
0000000000000000
[Â 139.943872] R10: ffffffff826174a0 R11: ffffc9000006bcb4 R12:
0000000000016120
[Â 139.943872] R13: 0000000000016120 R14: 0000000000016128 R15:
0000000000000000
[Â 139.943872] FS:Â 0000000000000000(0000) GS:ffff88803fc00000(0000)
knlGS:0000000000000000
[Â 139.943872] CS:Â 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[Â 139.943872] CR2: 00007f704be8b000 CR3: 000000003901a004 CR4:
00000000000606f0
[Â 139.943872] Kernel panic - not syncing: Fatal exception
[Â 139.943872] Shutting down cpus with NMI
[Â 143.927559] Kernel Offset: disabled
root@ovs104>