Re: linux-next: Tree for Jul 15 (drivers/phy/allwinner/phy-sun4i-usb.c)

[Vinod Koul]

On 15-07-20, 08:18, Randy Dunlap wrote:
> On 7/15/20 1:05 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20200714:
> > 
> 
> on x86_64:
> # CONFIG_GPIOLIB is not set
> 
> ../drivers/phy/allwinner/phy-sun4i-usb.c: In function âsun4i_usb_phy0_get_id_detâ:
> ../drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit declaration of function âgpiod_get_value_cansleepâ; did you mean âgpio_get_value_cansleepâ? [-Werror=implicit-function-declaration]
>     return gpiod_get_value_cansleep(data->id_det_gpio);
>            ^~~~~~~~~~~~~~~~~~~~~~~~
>            gpio_get_value_cansleep
>   CC      fs/bad_inode.o
> ../drivers/phy/allwinner/phy-sun4i-usb.c: In function âsun4i_usb_phy_probeâ:
> ../drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit declaration of function âdevm_gpiod_get_optionalâ; did you mean âdevm_clk_get_optionalâ? [-Werror=implicit-function-declaration]
>   data->id_det_gpio = devm_gpiod_get_optional(dev, "usb0_id_det",
>                       ^~~~~~~~~~~~~~~~~~~~~~~
>                       devm_clk_get_optional
> ../drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: âGPIOD_INâ undeclared (first use in this function); did you mean âGPIOF_INâ?
>            GPIOD_IN);
>            ^~~~~~~~
>            GPIOF_IN
> ../drivers/phy/allwinner/phy-sun4i-usb.c:708:11: note: each undeclared identifier is reported only once for each function it appears in
> ../drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit declaration of function âgpiod_to_irqâ; did you mean âgpio_to_irqâ? [-Werror=implicit-function-declaration]
>   data->id_det_irq = gpiod_to_irq(data->id_det_gpio);
>                      ^~~~~~~~~~~~
>                      gpio_to_irq
> 
> 
> Full randconfig file is attached.

Thanks Randy for the report, it is fixed by adding the right gpio
header, sending a patch now

-- 
~Vinod