Re: [PATCH] sound/pci/hda: Changes 'blacklist/whitelist' to 'blocklist/allowlist'

[Takashi Iwai]

On Wed, 15 Jul 2020 20:45:43 +0200,
Paul Schulz wrote:
> 
> Good news is that appears to be the only case of this particular usage
> with MODULE_PARM_DESC
> Searching for 'blacklist' and MODULE_PARM gives the following:
> 
> sound/pci/hda/hda_intel.c:183:MODULE_PARM_DESC(pm_blacklist, "Enable
> power-management blacklist");

Note that the blacklist/whitelist words have been already replaced in
sound/*, while this module option name was left intact for
compatibility.

At the next time, please include the proper subsystem ML to Cc.


thanks,

Takashi

> arch/x86/crypto/camellia_glue.c:1473:MODULE_PARM_DESC(force, "Force
> module load, ignore CPU blacklist");
> arch/x86/crypto/twofish_glue_3way.c:251:MODULE_PARM_DESC(force, "Force
> module load, ignore CPU blacklist");
> arch/x86/crypto/des3_ede_glue.c:467:MODULE_PARM_DESC(force, "Force
> module load, ignore CPU blacklist");
> arch/x86/crypto/blowfish_glue.c:423:MODULE_PARM_DESC(force, "Force
> module load, ignore CPU blacklist");
> 
> On Thu, 16 Jul 2020 at 03:45, Paul Schulz <paul@xxxxxxxxxxxxxxx> wrote:
> >
> > Yep. +1 for logic
> >
> > On Thu, 16 Jul 2020 at 03:11, Jonathan Corbet <corbet@xxxxxxx> wrote:
> > >
> > > On Thu, 16 Jul 2020 01:52:04 +0930
> > > Paul Schulz <paul@xxxxxxxxxxxxxxx> wrote:
> > >
> > > > -static bool pm_blacklist = true;
> > > > -module_param(pm_blacklist, bool, 0644);
> > > > -MODULE_PARM_DESC(pm_blacklist, "Enable power-management blacklist");
> > > > +static bool pm_blocklist = true;
> > > > +module_param(pm_blocklist, bool, 0644);
> > > > +MODULE_PARM_DESC(pm_blocklist, "Enable power-management blocklist");
> > >
> > > This will break any user specifying this parameter now, which isn't
> > > something you want to do, methinks...
> > >
> > > jon
>