Hi!
First, let's substitute multi.color -> multicolor globally,
LEDS_CLASS_MULTI_COLOR is most visible example of this. Please also
decide whether it is MultiColor or multicolor, and make it consistent.
OKIntroduce a multicolor class that groups colored LEDsFor example here. Plus, the LEDs are not neccessarily monochrome, we
within a LED node.
The multi color class groups monochrome LEDs and allows controlling two
support white LEDs, too. Let's use "simple LEDs"?
ok
aspects of the final combined color: hue and lightness. The former is"single color" -> "simple"?
controlled via the intensity file and the latter is controlled
via brightness file.
+ depends on LEDS_CLASS
+ help
+ This option enables the multicolor LED sysfs class in /sys/class/leds.
+ It wraps LED class and adds multicolor LED specific sysfs attributes
+ and kernel internal API to it. You'll need this to provide support
+ for multicolor LEDs that are grouped together. This class is not
+ intended for single color LEDs. It can be built as a module.
+ /* account for the new line at the end of the buffer */"new line" -> "newline", and actually check that character you are
+ offset++;
+ if (offset < size) {
+ ret = -EINVAL;
+ goto err_out;
+ }
skipping is newline. Someone could put '%' in there...
+ if (i < mcled_cdev->num_colors - 1)Using sprintf for single character has... quite a lot of
+ len += sprintf(buf + len, " ");
+ len += sprintf(buf + len, "\n");
overhead. Something like buf[len++] = '\n' would be
simpler/shorter/better. Please fix all relevant places.
Note I already applied patches 1-4.
Best regards,
Pavel