Re: [PATCH] ASoC: Intel: bytcht_es8316: Add missed put_device()

[Pierre-Louis Bossart]

> > > > snd_byt_cht_es8316_mc_probe() misses to call put_device() in an error
> > > > path. Add the missed function call to fix it.
> > > >
> > > > Fixes: ba49cf6f8e4a ("ASoC: Intel: bytcht_es8316: Add quirk for 
> > > > inverted jack detect")
> > > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
> > >
> > > Patch looks good to me:
> > >
> > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >
> > Actually the existing code looks quite odd to me:
> >
> > if (cnt) {
> > ÂÂÂÂÂret = device_add_properties(codec_dev, props);
> > ÂÂÂÂÂif (ret)
> > ÂÂÂÂÂÂÂÂ return ret;
> > }
> >
> > devm_acpi_dev_add_driver_gpios(codec_dev, byt_cht_es8316_gpios);
> > priv->speaker_en_gpio =
> > ÂÂÂÂÂgpiod_get_index(codec_dev, "speaker-enable", 0,
> > ÂÂÂÂÂÂÂÂÂÂÂÂ /* see comment in byt_cht_es8316_resume */
> > ÂÂÂÂÂÂÂÂÂÂÂÂ GPIOD_OUT_LOW | GPIOD_FLAGS_BIT_NONEXCLUSIVE);
> > put_device(codec_dev);
> >
> > if the first branch is not taken the put_device() will not be balanced.
>
> The get_device() does not come from the device_add_properties, it comes
> from the earlier:
>
> codec_dev = bus_find_device_by_name(&i2c_bus_type, NULL, codec_name);
>
> call.

I probably needed more coffee when I wrote this, indeed this is fine...

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>