Re: [PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting

[Rajendra Nayak]

On 7/17/2020 5:13 AM, Bjorn Andersson wrote:
> On Wed 15 Jul 22:42 PDT 2020, Rajendra Nayak wrote:
>
> > Add an optional power domain which when specified can be used for
> > setting the performance state of Venus.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> > ---
> > This is a resend of https://lore.kernel.org/patchwork/patch/1241077/
> >
> >   Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml    | 6 +++++-
> >   Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
> >   2 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> > index 55f2d67..1e8675b 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> > @@ -25,12 +25,16 @@ properties:
> >       maxItems: 1
> >   
> >     power-domains:
> > -    maxItems: 2
> > +    minItems: 2
> > +    maxItems: 3
> >   
> >     power-domain-names:
> > +    minItems: 2
> > +    maxItems: 3
> >       items:
> >         - const: venus
> >         - const: vcodec0
> > +      - const: opp-pd
>
> In line with Rob's question, the "opp power-domain" seems like a
> software construct, wouldn't this be better named e.g. "cx"?

The reason I chose to call it 'opp-pd' was to signify its the domain
that supports scaling (performance state) and not something that's just
turned on/off. I am fine calling it cx if that makes it look more 'real'

> Regards,
> Bjorn
>
> >   
> >     clocks:
> >       maxItems: 5
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> > index 157dff8..437286d 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> > @@ -25,13 +25,17 @@ properties:
> >       maxItems: 1
> >   
> >     power-domains:
> > -    maxItems: 3
> > +    minItems: 3
> > +    maxItems: 4
> >   
> >     power-domain-names:
> > +    minItems: 3
> > +    maxItems: 4
> >       items:
> >         - const: venus
> >         - const: vcodec0
> >         - const: vcodec1
> > +      - const: opp-pd
> >   
> >     clocks:
> >       maxItems: 7
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> > of Code Aurora Forum, hosted by The Linux Foundation

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation