Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

[wanghai (M)]

在 2020/7/18 9:39, David Miller 写道:
> From: Wang Hai <wanghai38@xxxxxxxxxx>
> Date: Fri, 17 Jul 2020 14:21:17 +0800
>
> > The driver forgets to call destroy_workqueue when cxgb3 probe fails.
> > Add the missed calls to fix it.
> >
> > Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.")
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Wang Hai <wanghai38@xxxxxxxxxx>
> You have to handle the case that the probing of one or more devices
> fails yet one or more others succeed.
>
> And you can't know in advance how this will play out.
>
> This is why the workqueue is unconditionally created, and only destroyed
> on module remove.
>
> .
Thanks for your explanation. I got it.