Re: [PATCH 20/30] iio: adc: max1363: Fix kerneldoc attribute formatting for 'lock'

From: Jonathan Cameron
Date: Sat Jul 18 2020 - 11:56:10 EST


On Fri, 17 Jul 2020 17:55:28 +0100
Lee Jones <lee.jones@xxxxxxxxxx> wrote:

> Kerneldoc expects attributes/parameters to be in '@*.: ' format.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/iio/adc/max1363.c:190: warning: Function parameter or member 'lock' not described in 'max1363_state'
>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: Rohit Sarkar <rohitsarkar5398@xxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Given the age of this driver, I suspect that this is the source
of all the cut and paste. Oops.

Applied,

Jonathan

> ---
> drivers/iio/adc/max1363.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index 9d92017c79b2d..0fe348a47fe01 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -150,7 +150,7 @@ struct max1363_chip_info {
> * @current_mode: the scan mode of this chip
> * @requestedmask: a valid requested set of channels
> * @reg: supply regulator
> - * @lock lock to ensure state is consistent
> + * @lock: lock to ensure state is consistent
> * @monitor_on: whether monitor mode is enabled
> * @monitor_speed: parameter corresponding to device monitor speed setting
> * @mask_high: bitmask for enabled high thresholds