Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml

From: Guido Günther
Date: Sat Jul 18 2020 - 12:52:24 EST

Hi,
On Fri, Jul 03, 2020 at 01:47:16PM +0200, Ondrej Jirman wrote:
> The example is now validated against rocktech,jh057n00900 schema
> that was ported to yaml, and didn't validate with:
>
> - '#address-cells', '#size-cells', 'port@0' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> - 'vcc-supply' is a required property
> - 'iovcc-supply' is a required property
> - 'reset-gpios' is a required property
>
> Fix it.
>
> Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>
> ---
> .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> index 8aff2d68fc33..2c4c34e3bc29 100644
> --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
> @@ -165,6 +165,7 @@ examples:
> - |
>
> #include <dt-bindings/clock/imx8mq-clock.h>
> + #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/imx8mq-reset.h>
>
> @@ -191,12 +192,12 @@ examples:
> phy-names = "dphy";
>
> panel@0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> compatible = "rocktech,jh057n00900";
> reg = <0>;
> - port@0 {
> - reg = <0>;
> + vcc-supply = <&reg_2v8_p>;
> + iovcc-supply = <&reg_1v8_p>;
> + reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
> + port {
> panel_in: endpoint {
> remote-endpoint = <&mipi_dsi_out>;
> };

Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
-- Guido