Re: [PATCH v2] powerpc/powernv/pci: use ifdef to avoid dead code

From: Greg Thelen
Date: Sat Jul 18 2020 - 15:17:57 EST


Oliver O'Halloran <oohall@xxxxxxxxx> wrote:

> On Mon, Jun 15, 2020 at 9:33 AM Greg Thelen <gthelen@xxxxxxxxxx> wrote:
>>
>> Commit dc3d8f85bb57 ("powerpc/powernv/pci: Re-work bus PE
>> configuration") removed a couple pnv_ioda_setup_bus_dma() calls. The
>> only remaining calls are behind CONFIG_IOMMU_API. Thus builds without
>> CONFIG_IOMMU_API see:
>> arch/powerpc/platforms/powernv/pci-ioda.c:1888:13: error: 'pnv_ioda_setup_bus_dma' defined but not used
>>
>> Move pnv_ioda_setup_bus_dma() under CONFIG_IOMMU_API to avoid dead code.
>
> Doh! Thanks for the fix.
>
> Reviewed-by: Oliver O'Halloran <oohall@xxxxxxxxx>

Is there anything else needed from me on this patch?
Given that it fixes a 5.8 commit I figured it'd be 5.8 material.