Re: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage

From: Paul E. McKenney
Date: Sun Jul 19 2020 - 12:08:26 EST


On Sun, Jul 19, 2020 at 05:52:44PM +0530, Naresh Kamboju wrote:
> On Sat, 18 Jul 2020 at 05:43, Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
> >
> > On Sat, Jul 18, 2020 at 12:35:12AM +0530, Naresh Kamboju wrote:
> > > Hi Paul,
> > >
> > > > I am not seeing this here.
> > >
> > > Do you notice any warnings while building linux next master
> > > for x86_64 architecture ?
> >
> > Idiot here was failing to enable building of KVM. With that, I do see
> > the error. The patch resolves it for me. Does it help for you?
>
> yes.
> The below patch applied on top of linux -next 20200717 tag
> and build pass.

Thank you! May I add your Tested-by?

Thanx, Paul

> > ------------------------------------------------------------------------
> >
> > diff --git a/include/linux/rculist.h b/include/linux/rculist.h
> > index de9385b..f8633d3 100644
> > --- a/include/linux/rculist.h
> > +++ b/include/linux/rculist.h
> > @@ -73,7 +73,7 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head *list)
> > #define __list_check_rcu(dummy, cond, extra...) \
> > ({ check_arg_count_one(extra); })
> >
> > -#define __list_check_srcu(cond) true
> > +#define __list_check_srcu(cond) ({ })
> > #endif
> >
> > /*
>
> - Naresh