Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

[Bixuan Cui]

On 2020/7/20 1:05, Stephen Hemminger wrote:
> On Thu, 16 Jul 2020 17:32:47 +0000
> Bixuan Cui <cuibixuan@xxxxxxxxxx> wrote:
> 
>> Fix the warning: [-Werror=-Wframe-larger-than=]
>>
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:
>> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
>> warning: the frame size of 1056 bytes is larger than 1024 bytes
>>
>> Signed-off-by: Bixuan Cui <cuibixuan@xxxxxxxxxx>
> Dropping the NR_SKB_COMPLETED to 16 won't have much impact
> on performance, and shrink the size.
> 
> Doing 16 skb's at a time instead of 128 probably costs
> less than one allocation. Especially since it is unlikely
> that the device completed that many transmits at once.
> 
> 
I will send the v2 patch based on your suggestions.
thanks