Re: [PATCH] misc: rtsx: Add support new chip rts5228 mmc: rtsx: Add support MMC_CAP2_NO_MMC

[Linus Walleij]

On Mon, Jul 6, 2020 at 9:03 AM <ricky_wu@xxxxxxxxxxx> wrote:

>  drivers/misc/cardreader/Makefile   |   2 +-
>  drivers/misc/cardreader/rts5228.c  | 740 +++++++++++++++++++++++++++++
>  drivers/misc/cardreader/rts5228.h  | 168 +++++++
>  drivers/misc/cardreader/rtsx_pcr.c |  89 ++--
>  drivers/misc/cardreader/rtsx_pcr.h |   5 +

This drivers/misc/cardreader business is a big confusion for my mind.

Is it really that fantastic that it needs to be a unique special case?

To me it looks like a drivers/mfd thing which should have separate
drivers/regulator/rts5228.c (LDOs)
drivers/clk/rts5228.c (clocks)
subdrivers.

See for example drivers/mfd/sta2x11-mfd.c thay spawns a few
devices off a PCI card.

Yours,
Linus Walleij