Re: [PATCH] misc: rtsx: Add support new chip rts5228 mmc: rtsx: Add support MMC_CAP2_NO_MMC

[Lee Jones]

On Mon, 20 Jul 2020, Lee Jones wrote:

> On Mon, 20 Jul 2020, Linus Walleij wrote:
> 
> > On Mon, Jul 6, 2020 at 9:03 AM <ricky_wu@xxxxxxxxxxx> wrote:
> > 
> > >  drivers/misc/cardreader/Makefile   |   2 +-
> > >  drivers/misc/cardreader/rts5228.c  | 740 +++++++++++++++++++++++++++++
> > >  drivers/misc/cardreader/rts5228.h  | 168 +++++++
> > >  drivers/misc/cardreader/rtsx_pcr.c |  89 ++--
> > >  drivers/misc/cardreader/rtsx_pcr.h |   5 +
> > 
> > This drivers/misc/cardreader business is a big confusion for my mind.
> > 
> > Is it really that fantastic that it needs to be a unique special case?
> > 
> > To me it looks like a drivers/mfd thing which should have separate
> > drivers/regulator/rts5228.c (LDOs)
> > drivers/clk/rts5228.c (clocks)
> > subdrivers.
> > 
> > See for example drivers/mfd/sta2x11-mfd.c thay spawns a few
> > devices off a PCI card.
> 
> Thanks for Cc'ing me Linus.
> 
> Can you please bounce the diff to me too?

Never mind, I found it.

So you may use MFD to register the (regulator, clk, card reader) child
devices, but pretty much none of that *functional* code belongs in
drivers/mfd.

-- 
Lee Jones [æçæ]
Senior Technical Lead - Developer Services
Linaro.org â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog