RE: [PATCH v2][next] phy: samsung-ufs: Fix IS_ERR argument

[Alim Akhtar]

Hi Gustavo,

> -----Original Message-----
> From: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> Sent: 20 July 2020 18:57
> To: Kishon Vijay Abraham I <kishon@xxxxxx>; Vinod Koul <vkoul@xxxxxxxxxx>;
> Seungwon Jeon <essuuj@xxxxxxxxx>; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>; Kiwoong Kim <kwmad.kim@xxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Gustavo A. R. Silva
<gustavoars@xxxxxxxxxx>
> Subject: [PATCH v2][next] phy: samsung-ufs: Fix IS_ERR argument
> 
> Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper
> argument to be passed to IS_ERR() is phy->rx1_symbol_clk.
> 
> This bug was detected with the help of Coccinelle.
> 
> Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung
SoC")
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> Changes in v2:
>  - Update subject line and changelog text.
> 
>  drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
> b/drivers/phy/samsung/phy-samsung-ufs.c
> index 43ef77d1d96c..9832599a0283 100644
> --- a/drivers/phy/samsung/phy-samsung-ufs.c
> +++ b/drivers/phy/samsung/phy-samsung-ufs.c
> @@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct
> samsung_ufs_phy *phy)
>  	}
> 
>  	phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
> -	if (IS_ERR(phy->rx0_symbol_clk)) {
> +	if (IS_ERR(phy->rx1_symbol_clk)) {
>  		dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
>  		return PTR_ERR(phy->rx1_symbol_clk);
>  	}
> --
> 2.27.0