Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

From: Leon Romanovsky
Date: Tue Jul 21 2020 - 02:05:43 EST


On Mon, Jul 20, 2020 at 11:34:00PM +0200, Alexander A. Klimov wrote:
>
>
> Am 20.07.20 um 18:48 schrieb Leon Romanovsky:
> > On Mon, Jul 20, 2020 at 08:36:35AM -0600, Jonathan Corbet wrote:
> > > On Mon, 20 Jul 2020 17:07:16 +0300
> > > Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > >
> > > > > Do *you* want to review that megapatch? The number of issues that have
> This question is... interesting.
> And no, I would not.

You are EXPECTED to review your work prior sending to the mailing list.

>
> > > > > come up make it clear that these patches do, indeed, need review...
> > > >
> > > > Can you point me to the issues?
> > > > What can go wrong with such a simple replacement?
> > >
> > > Some bits of the conversation:
> > >
> > > https://lore.kernel.org/lkml/20200626110219.7ae21265@xxxxxxx/
> > > https://lore.kernel.org/lkml/20200626110706.7b5d4a38@xxxxxxx/
> > > https://lore.kernel.org/lkml/20200705142506.1f26a7e0@xxxxxxx/
> > > https://lore.kernel.org/lkml/20200713114321.783f0ae6@xxxxxxx/
> > > https://lore.kernel.org/lkml/202007081531.085533FC5@keescook/
> > >
> > > etc.
> >
> > After reading your links and especially this one.
> > https://lore.kernel.org/lkml/20200713114321.783f0ae6@xxxxxxx/
> > I don't understand why are we still seeing these patches?
> >
> > I gave to the author comments too, which were ignored.
> > https://patchwork.kernel.org/patch/11644683/#23466547
> I've added SPDXing (the automated way of course ;) ) to my todo list.

OMG, why don't you listen? We don't want your automatic patches.

Thanks

>
> >
> > Thanks
> >
> > >
> > > jon