Re: [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

From: Gustavo A. R. Silva
Date: Tue Jul 21 2020 - 23:46:13 EST


Hi Geert,

On 7/17/20 02:18, Geert Uytterhoeven wrote:
> Hi Gustavo,
>
> Thanks for your patch!
>
> On Thu, Jul 16, 2020 at 11:11 PM Gustavo A. R. Silva
> <gustavoars@xxxxxxxxxx> wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
>> fall-through markings when it is the case.
>
> Which unnecessary marking is being removed?
> I don't see any.
>

There is none. I will remove those lines and send v2 with a URL
to the proper documentation for Linux v5.7 instead of 'lastest',
see:

https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

I'll add your Reviewed-by tag. :)

>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>
> For the actual patch contents:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>

Thanks!
--
Gustavo