Re: [PATCH v3 4/4] irqchip/mtk-cirq: Convert to a platform driver

From: Hanks Chen
Date: Thu Jul 23 2020 - 07:46:11 EST


On Fri, 2020-07-17 at 17:06 -0700, Saravana Kannan wrote:
> This driver can work as a platform driver. So covert it to a platform
> driver.
>
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> ---
> drivers/irqchip/irq-mtk-cirq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
> index 69ba8ce3c178..62a61275aaa3 100644
> --- a/drivers/irqchip/irq-mtk-cirq.c
> +++ b/drivers/irqchip/irq-mtk-cirq.c
> @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node,
> return ret;
> }
>
> -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init);
> +IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_cirq)
> +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init)
> +IRQCHIP_PLATFORM_DRIVER_END(mtk_cirq)

Hi Saravana,

Looks good for me to convert cirq to a platform.
Thank you for your patch.

Reviewed-by: Hanks Chen <hanks.chen@xxxxxxxxxxxx>

Hanks Chen