Re: [PATCH] MIPS: BCM63xx: improve CFE version detection
From: Thomas Bogendoerfer
Date: Fri Jul 24 2020 - 07:48:11 EST
On Mon, Jun 08, 2020 at 11:28:35AM +0200, Álvaro Fernández Rojas wrote:
> There are some CFE variants that start with 'cfe-vd' instead of 'cfe-v', such
> as the one used in the Huawei HG556a: "cfe-vd081.5003". In this case, the CFE
> version is stored as is (string vs number bytes).
> Some newer devices have an additional version number, such as the Comtrend
> VR-3032u: "1.0.38-112.118-11".
> Finally, print the string as is if the version doesn't start with "cfe-v" or
> "cfe-vd", but starts with "cfe-".
> Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>
> arch/mips/bcm63xx/boards/board_bcm963xx.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
applied to mips-next.
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]