Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

From: Greg Kroah-Hartman
Date: Fri Jul 24 2020 - 09:28:40 EST

On Fri, Jul 24, 2020 at 08:29:55PM +0800, Dinghao Liu wrote:
> The variable authmode will keep uninitialized if neither if
> statements used to initialize this variable are not triggered.
> Then authmode may contain a garbage value and influence the
> execution flow of this function.
> Fix this by initializing it to zero.

That does not fix anything, you just now are potentially setting a value
you really do not have.

Are you sure that this variable really will never be set? If so, please
fix it up with a "real" value that the code can handle properly.


greg k-h