Re: [PATCH v2 05/29] memory: jz4780-nemc: Do not enable by default on every compile test
From: Krzysztof Kozlowski
Date: Fri Jul 24 2020 - 09:53:19 EST
On Fri, Jul 24, 2020 at 03:45:37PM +0200, Arnd Bergmann wrote:
> On Fri, Jul 24, 2020 at 9:41 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > When compile testing, enable the driver by default only on MIPS
> > architecture.
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > ---
> > Changes since v1:
> > 1. New patch
> @@ -141,7 +141,7 @@ config FSL_IFC
> > config JZ4780_NEMC
> > bool "Ingenic JZ4780 SoC NEMC driver"
> > - default y
> > + default y if MIPS
> > depends on MIPS || COMPILE_TEST
> Actually I think this should be 'default MACH_INGENIC',
> and probably also 'depends on MACH_INGENIC || COMPILE_TEST'.
Makes sense, especially for default.
For the depends, there is also MTD_NAND_JZ4780 (depending on
JZ4780_NEMC) which also requires MIPS. I could fix both then.