Re: [PATCH v7 3/3] arm64: implement KPROBES_ON_FTRACE
From: Masami Hiramatsu
Date: Fri Jul 24 2020 - 12:54:56 EST
On Fri, 24 Jul 2020 15:06:11 +0800
Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx> wrote:
> On Tue, 21 Jul 2020 22:24:55 +0900 Masami Hiramatsu wrote:
> > Hi Jisheng,
> > Would you be still working on this series?
> I will rebase the implementation on the latest code, then try to address
> your comments and Mark's comments. I will send out patches in this weekend.
> > If you are still want to put a probe on func+4, it is OK if you can
> > completely emulate the 1st instruction. (lr save on the stack and
> > change the regs->sp)
> Will check which is the better solution.
What I'm considering is the consistency of pre_handler()@addr and
post_handler()@addr+4. Also, whether the value of regs (and stacks) is
same as the user expected.
Masami Hiramatsu <mhiramat@xxxxxxxxxx>