Re: [PATCH] media: davinci: vpif_capture: fix potential double free

From: Evgeny Novikov
Date: Fri Jul 24 2020 - 16:08:08 EST

Hi Markus,

It seems that Lad Prabhakar detected a critical issue introduced by the patch instead of a minor bug fixed by it. So, we should take care of this first, but I will address your notes as well.

Evgeny Novikov
Linux Verification Center, ISP RAS

23.07.2020, 23:15, "Markus Elfring" <markus.elfring@xxxxxx>:
>> ÂIn case of errors vpif_probe_complete() releases memory for
>> Âand unregisters the V4L2 device. But then this is done again by
>> Âvpif_probe() itself. The patch removes the cleaning from
>> Âvpif_probe_complete().
> * An imperative wording can be preferred for the change description,
> ÂÂcan't it?
> * Would you like to add the tag âFixesâ to the commit message?
> Regards,
> Markus