Re: [PATCH RFC leds + net-next v2 0/1] Add support for LEDs on Marvell PHYs
From: Pavel Machek
Date: Fri Jul 24 2020 - 18:38:49 EST
On Fri 2020-07-24 15:12:33, Marek Behún wrote:
> On Fri, 24 Jul 2020 12:29:01 +0200
> Pavel Machek <pavel@xxxxxx> wrote:
> > In future, would you expect having software "1000/100/10/nolink"
> > triggers I could activate on my scrollock LED (or on GPIO controlled
> > LEDs) to indicate network activity?
> Look at drivers/net/phy/phy_led_triggers.c, something like that could
> be actually implemented there.
> Some of the modes are useful, like the "1000/100/10/nolink". But some
> of them are pretty weird, and I don't think anyone actually uses it
> ("1000-10/else", which is on if the device is linked at 1000mbps ar
> 10mbps, and else off? who would sacrifies a LED for this?).
> I actually wanted to talk about the phy_led_triggers.c code. It
> registers several trigger for each PHY, with the name in form:
> phy-device-name is derived from OF
> - sometimes it is in the form
> - but sometimes in the form of whole OF path followed by ":" and
> the PHY address:
> mode is "link", "1Gbps", "100Mbps", "10Mbps" and so on"
> So I have a GPIO LED, and I can set it to sw trigger so that it is on
> when a specific PHY is linked on 1Gbps.
> The problem is that on Turris Mox I can connect up to three 8-port
> switches, which yields in 25 network PHYs overall. So reading the
> trigger file results in 4290 bytes (look at attachment cat_trigger.txt).
> I think the phy_led_triggers should have gone this way of having just
> one trigger (like netdev has), and specifying phy device via and mode
> via another file.
I agree with you. This is ... not pretty ... and it would be nice to
get it fixed.
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Description: Digital signature