Re: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init()

From: Markus Elfring
Date: Sat Jul 25 2020 - 08:03:35 EST


> The variable np in function m10v_smp_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it.

Such information is useful.


> If this node is not put it may cause a memory leak.

Is the reference management generally improvable for this function implementation?


Will the tag âFixesâ become helpful for the commit message?

Regards,
Markus