Re: [PATCH v6 4/9] hwmon: pmbus: adm1266: add debugfs for states

From: kernel test robot
Date: Mon Jul 27 2020 - 03:40:13 EST


I love your patch! Perhaps something to improve:

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on linux/master robh/for-next linus/master v5.8-rc7 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: hwmon-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/hwmon/pmbus/adm1266.c: In function 'adm1266_init_debugfs':
>> drivers/hwmon/pmbus/adm1266.c:309:17: warning: variable 'entry' set but not used [-Wunused-but-set-variable]
309 | struct dentry *entry;
| ^~~~~

vim +/entry +309 drivers/hwmon/pmbus/adm1266.c

307 static void adm1266_init_debugfs(struct adm1266_data *data)
308 {
> 309 struct dentry *entry;
310 struct dentry *root;
312 root = pmbus_get_debugfs_dir(data->client);
313 if (!root)
314 return;
316 data->debugfs_dir = debugfs_create_dir(data->client->name, root);
317 if (!data->debugfs_dir)
318 return;
320 entry = debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state",
321 data->debugfs_dir, adm1266_state_read);
322 }

0-DAY CI Kernel Test Service, Intel Corporation

Attachment: .config.gz
Description: application/gzip