Re: [PATCH v3] powercap: Add Power Limit4 support

From: Shevchenko, Andriy
Date: Mon Jul 27 2020 - 08:13:20 EST

On Mon, Jul 27, 2020 at 01:46:12PM +0200, Rafael J. Wysocki wrote:
> On Thu, Jul 16, 2020 at 7:38 PM Sumeet Pawnikar
> <sumeet.r.pawnikar@xxxxxxxxx> wrote:
> >
> > Modern Intel Mobile platforms support power limit4 (PL4), which is
> > the SoC package level maximum power limit (in Watts). It can be used
> > to preemptively limits potential SoC power to prevent power spikes
> > from tripping the power adapter and battery over-current protection.
> > This patch enables this feature by exposing package level peak power
> > capping control to userspace via RAPL sysfs interface. With this,
> > application like DTPF can modify PL4 power limit, the similar way
> > of other package power limit (PL1).
> > As this feature is not tested on previous generations, here it is
> > enabled only for the platform that has been verified to work,
> > for safety concerns.
> Queued up as 5.9 material ->
> > Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@xxxxxxxxx>
> > Co-developed-by: Zhang Rui <rui.zhang@xxxxxxxxx>
> > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
> -> with this tag removed, because the only case in which you can
> include an S-o-b from someone else is when you also add a From:
> pointing to that person. IOW, you add a From: with a matching S-o-b
> from someone else and you can add your own S-o-b to that.
> In this particular case, the C-d-b tag is sufficient to make a record
> of somebody else's contribution to a patch carrying a From: header
> that points to you (ie. your patch).

Rafael, it looks like it contradicts documentation. I mean your amendment.
SoB is specifically required to be coupled with Co-developed-by. That said,
both or none are acceptable. (I don't consider the chain of SoB when it goes
thru maintainers)

With Best Regards,
Andy Shevchenko