Re: [PATCH] counter: microchip-tcb-capture: check the correct variable

[William Breathitt Gray]

On Mon, Jul 27, 2020 at 02:23:16PM +0300, Dan Carpenter wrote:
> This should be testing "regmap" instead of "priv->regmap".  The
> "priv->regmap" variable is always zero so it's not an error pointer.
> 
> Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>

> ---
> The commit 106b104137fd ("counter: Add microchip TCB capture counter")
> doesn't use the correct patch prefix.  This is a common mistake for the
> the first commit which adds the driver.  There is no kernel wide
> standard for patch prefixes so it's difficult for people sending fixes
> to know the correct prefix should be.
> 
>  drivers/counter/microchip-tcb-capture.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> index f7b7743ddb94..b7b252c5addf 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -320,8 +320,8 @@ static int mchp_tc_probe(struct platform_device *pdev)
>  	}
>  
>  	regmap = syscon_node_to_regmap(np->parent);
> -	if (IS_ERR(priv->regmap))
> -		return PTR_ERR(priv->regmap);
> +	if (IS_ERR(regmap))
> +		return PTR_ERR(regmap);
>  
>  	/* max. channels number is 2 when in QDEC mode */
>  	priv->num_channels = of_property_count_u32_elems(np, "reg");
> -- 
> 2.27.0
>

Attachment: signature.asc
Description: PGP signature