Re: [PATCH] ACPI: APEI: remove redundant assignment to variable rc

From: Rafael J. Wysocki
Date: Mon Jul 27 2020 - 09:24:17 EST


On Wed, Jul 22, 2020 at 7:06 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable rc is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/acpi/apei/hest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 953a2fae8b15..6e980fe16772 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -227,7 +227,7 @@ __setup("hest_disable", setup_hest_disable);
> void __init acpi_hest_init(void)
> {
> acpi_status status;
> - int rc = -ENODEV;
> + int rc;
> unsigned int ghes_count = 0;
>
> if (hest_disable) {
> --

Applied as 5.9 material, thanks!