Re: [RESEND PATCH v3 2/2] mfd: madera: Improve handling of regulator unbinding

From: Lee Jones
Date: Mon Jul 27 2020 - 10:02:29 EST

On Thu, 23 Jul 2020, Charles Keepax wrote:

> The current unbinding process for Madera has some issues. The trouble
> is runtime PM is disabled as the first step of the process, but
> some of the drivers release IRQs causing regmap IRQ to issue a
> runtime get which fails. To allow runtime PM to remain enabled during
> mfd_remove_devices, the DCVDD regulator must remain available. In
> the case of external DCVDD's this is simple, the regulator can simply
> be disabled/put after the call to mfd_remove_devices. However, in
> the case of an internally supplied DCVDD the regulator needs to be
> released after the other MFD children depending on it.
> Use the new MFD mfd_remove_devices_late functionality to split
> the DCVDD regulator off from the other drivers.
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/mfd/madera-core.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)

Applied, thanks.

Lee Jones [æçæ]
Senior Technical Lead - Developer Services â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog