Re: [PATCH 3/6] ASoC: amd: SND_SOC_RT5682_I2C does not build rt5682

From: Pierre-Louis Bossart
Date: Mon Jul 27 2020 - 11:32:04 EST

On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote:
changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because,
This flag which was previously set as SND_SOC_RT5682
used to build rt5682 codec driver but by changing into
SND_SOC_RT5682_I2C is preventing to build rt5682 codec
driver and machine driver fails to probe.So Reverting the changes.

The split between I2C and SoundWire means you have to choose the I2C or SDW mode. Selecting the common part looks very strange.

see Intel machine drviers:

Kconfig: select SND_SOC_RT5682_I2C
Kconfig: select SND_SOC_RT5682_I2C
Kconfig: select SND_SOC_RT5682_I2C
Kconfig: select SND_SOC_RT5682_SDW

Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@xxxxxxx>
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index e37cf72f2bab..77ffdb41bee5 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -29,7 +29,7 @@ config SND_SOC_AMD_ACP3x
tristate "AMD RV support for RT5682"
- select SND_SOC_RT5682_I2C
+ select SND_SOC_RT5682
select SND_SOC_MAX98357A