Re: [PATCH for-5.8 v2] usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
From: Martin Blumenstingl
Date: Mon Jul 27 2020 - 13:35:58 EST
On Sun, Jul 26, 2020 at 12:04 PM Minas Harutyunyan
> Kernel test robot found issue:
> >> warning: unused label 'error_debugfs' [-Wunused-label]
> 1 warning generated.
> So, 'error_debugfs:' label should be under #if/#endif:
> #if IS_ENABLED(CONFIG_USB_DWC2_PERIPHERAL) || \
> #endif /* CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE */
> Or you have other suggestion?
unfortunately I have no better idea
> Could you please fix this issue and submit new version of patch.
I'm going to cover everything I add inside the same #if (not just the
if any additional label is added (above) in the future then the code
that I'm adding must not be executed when that #if evaluates to false
v3 is coming in the next few minutes.