Re: [PATCH v8 6/7] x86: Add support for ZSTD compressed kernel
From: Nick Terrell
Date: Mon Jul 27 2020 - 18:45:12 EST
> On Jul 24, 2020, at 7:30 AM, Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote:
> On Fri, Jul 24, 2020 at 02:50:34AM +0200, Sedat Dilek wrote:
>> On Thu, Jul 23, 2020 at 9:30 PM Nick Terrell <nickrterrell@xxxxxxxxx> wrote:
>>> From: Nick Terrell <terrelln@xxxxxx>
>>> * Add support for zstd compressed kernel
>>> * Define __DISABLE_EXPORTS in misc.c
>>> * Bump the heap size for zstd.
>>> * Update the documentation.
>>> Integrates the ZSTD decompression code to the x86 pre-boot code.
>>> Zstandard requires slightly more memory during the kernel decompression
>>> on x86 (192 KB vs 64 KB), and the memory usage is independent of the
>>> window size.
>>> __DISABLE_EXPORTS is defined in misc.c instead of the Makefile because
>>> kaslr.c defines __DISABLE_EXPORTS, and defining it in the Makefile gives
>>> duplicate definition warnings.
>> That was reported by Arvind - feel free to add a Reported-by: ...
>> - Sedat -
> It's not necessary to add Reported-by's for problems encountered while
> developing the series. Especially as it was my drive-by suggestion to
> use __DISABLE_EXPORTS that introduced the issue in the first place :)
> I'd have added it to the Makefile and just dropped the definition in
> kaslr.c -- should be no reason for anything in here to use EXPORT_SYMBOL.
Sure, I was a bit hesitant to modify more than necessary here, but I will go
ahead and do that.
Thanks for the reviews!