Re: [PATCH] perf record: Set PERF_RECORD_SAMPLE if attr->freq is set.

[Athira Rajeev]

> On 27-Jul-2020, at 12:29 PM, Ian Rogers <irogers@xxxxxxxxxx> wrote:
> 
> From: David Sharp <dhsharp@xxxxxxxxxx>
> 
> evsel__config() would only set PERF_RECORD_SAMPLE if it set attr->freq

Hi Ian,

Commit message says PERF_RECORD_SAMPLE. But since we are setting period here, it has to say âPERF_SAMPLE_PERIODâ ?


Thanks
Athira 

> from perf record options. When it is set by libpfm events, it would not
> get set. This changes evsel__config to see if attr->freq is set outside of
> whether or not it changes attr->freq itself.
> 
> Signed-off-by: David Sharp <dhsharp@xxxxxxxxxx>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/util/evsel.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index ef802f6d40c1..811f538f7d77 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -979,13 +979,18 @@ void evsel__config(struct evsel *evsel, struct record_opts *opts,
> 	if (!attr->sample_period || (opts->user_freq != UINT_MAX ||
> 				     opts->user_interval != ULLONG_MAX)) {
> 		if (opts->freq) {
> -			evsel__set_sample_bit(evsel, PERIOD);
> 			attr->freq		= 1;
> 			attr->sample_freq	= opts->freq;
> 		} else {
> 			attr->sample_period = opts->default_interval;
> 		}
> 	}
> +	/*
> +	 * If attr->freq was set (here or earlier), ask for period
> +	 * to be sampled.
> +	 */
> +	if (attr->freq)
> +		evsel__set_sample_bit(evsel, PERIOD);
> 
> 	if (opts->no_samples)
> 		attr->sample_freq = 0;
> -- 
> 2.28.0.rc0.142.g3c755180ce-goog
> 
> 
>