Re: [RESEND PATCH v2] mfd: syscon: Use a unique name with regmap_config
From: Lee Jones
Date: Tue Jul 28 2020 - 04:01:45 EST
On Mon, 27 Jul 2020, Suman Anna wrote:
> The DT node full name is currently being used in regmap_config
> which in turn is used to create the regmap debugfs directories.
> This name however is not guaranteed to be unique and the regmap
> debugfs registration can fail in the cases where the syscon nodes
> have the same unit-address but are present in different DT node
> hierarchies. Replace this logic using the syscon reg resource
> address instead (inspired from logic used while creating platform
> devices) to ensure a unique name is given for each syscon.
> Signed-off-by: Suman Anna <s-anna@xxxxxx>
> Hi Arnd,
> Lee is looking for your review on this patch. Can you please
> review and provide your comments.
> This is a resend of the patch that was posted previously, rebased
> now onto latest kernel.
> v2: https://patchwork.kernel.org/patch/11353355/
> - Fix build warning reported by kbuild test bot
> v1: https://patchwork.kernel.org/patch/11346363/
> drivers/mfd/syscon.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Lee Jones [æçæ]
Senior Technical Lead - Developer Services
Linaro.org â Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog