Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone

[Martin Kepplinger]

On 27.07.20 14:02, Pavel Machek wrote:
> Hi!
> 
>> +	pwmleds {
>> +		compatible = "pwm-leds";
>> +
>> +		blue {
>> +			label = "blue:status";
>> +			max-brightness = <248>;
>> +			pwms = <&pwm2 0 50000>;
>> +		};
>> +
>> +		green {
>> +			label = "green:status";
>> +			max-brightness = <248>;
>> +			pwms = <&pwm4 0 50000>;
>> +		};
>> +
>> +		red {
>> +			label = "red:status";
>> +			max-brightness = <248>;
>> +			pwms = <&pwm3 0 50000>;
>> +		};
>> +	};
> 
> Can we postpone this?

I guess we can. It's indeed easier to add that interface once we know we
can use a stable one.

> 
> 1) green:status is not really name used anywhere else
> 
> 2) this should really use multicolor framework, as it is single LED,
> not three of them.
> 
> Fixing that in future will be hard :-(.
> 								Pavel
> 								
> 

thanks,
                              martin