Re: [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t

From: David Howells
Date: Tue Jul 28 2020 - 07:02:03 EST


Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> > I've been gradually undoing some of the conversions as there's no equivalent
> > of atomic_add_return() and atomic_dec_return() that allow me to log the
> > altered refcount through a tracepoint.
>
> Please do not _undo_ the changes; just add the API you need.

And _please_ do not convert atomic_inc/dec_return() into refcount_read() +
refcount_xxx(). They are _not_ equivalent.

David