Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type

From: Ralph Campbell
Date: Tue Jul 28 2020 - 16:57:34 EST



On 7/28/20 12:15 PM, Jason Gunthorpe wrote:
On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote:
static inline int mm_has_notifiers(struct mm_struct *mm)
@@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,
range->start = start;
range->end = end;
range->flags = flags;
+ range->migrate_pgmap_owner = NULL;
}

Since this function is commonly called and nobody should read
migrate_pgmap_owner unless MMU_NOTIFY_MIGRATE is set as the event,
this assignment can be dropped.

Jason

I agree.
Acked-by: Ralph Campbell <rcampbell@xxxxxxxxxx>