RE: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

From: Winkler, Tomas
Date: Tue Jul 28 2020 - 19:08:51 EST


> On Tue, 2020-07-28 at 22:14 +0000, Winkler, Tomas wrote:
> > > -----Original Message-----
> > > From: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> []
> > > I'm using this command:
> > >
> > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
> > >
> > > and this is the output for both files:
> > >
> > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
> > > drivers/misc/mei/hdcp/mei_hdcp.c Arnd Bergmann <arnd@xxxxxxxx>
> > > (supporter:CHAR and MISC DRIVERS) Greg Kroah-Hartman
> > > <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:CHAR and MISC DRIVERS)
> > > linux- kernel@xxxxxxxxxxxxxxx (open list) $
> > > scripts/get_maintainer.pl --nokeywords -- nogit --nogit-fallback
> > > drivers/misc/mei/hdcp/mei_hdcp.h Arnd Bergmann <arnd@xxxxxxxx>
> > > (supporter:CHAR and MISC DRIVERS) Greg Kroah-Hartman
> > > <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:CHAR and MISC DRIVERS)
> > > linux- kernel@xxxxxxxxxxxxxxx (open list) For some reason you don't
> > > appear on the list above. Do you see anything wrong with the command
> I'm running to get the maintainers and lists?
> >
> > Not sure, it should be caught by drivers/misc/mei/* ?
>
> No, this pattern matches _only_ files in that particular directory and not any
> files in any subdirectory.
>
> > Maybe it is not recursive?
>
> It depends on the pattern.
> Patterns with trailing slashes match subdirectories too.
>
> from MAINTAINERS:
>
> F: *Files* and directories wildcard patterns.
> A trailing slash includes all files and subdirectory files.
> F: drivers/net/ all files in and below drivers/net
> F: drivers/net/* all files in drivers/net, but not below
> F: */net/* all files in "any top level directory"/net
> One pattern per line. Multiple F: lines acceptable.
>
>
> > Need to check the script,
> > frankly I usually check this manually. prob
> >
> > INTEL MANAGEMENT ENGINE (mei)
> > M: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> > L: linux-kernel@xxxxxxxxxxxxxxx
> > S: Supported
> > F: Documentation/driver-api/mei/*
> > F: drivers/misc/mei/*
>
> You probably want:
>
> F: drivers/misc/mei/
Yes, thanks.
Tomas