Re: [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar,pmsleep

[Arnd Bergmann]

On Wed, Jul 29, 2020 at 11:14 AM Daniel Palmer <daniel@xxxxxxxx> wrote:
> On Wed, 29 Jul 2020 at 04:18, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> > > +      - items:
> > > +         - enum:
> > > +             - mstar,pmsleep
> >
> > Needs to be SoC specific. Random collections of bits are never
> > 'standard' from one SoC to the next.
>
> I don't have a manual for any of the chips so I can't say for sure but
> so far all of the chips in this group (ARMv7 based MStar/Sigmastar)
> has the same layout for the registers i.e. the reset register,
> the resume address registers are at the same place for all of them.
>
> Does calling it "mstar,pmsleepv7" make more sense? I'm not sure what
> to call it really.

Use the name of the oldest chip you know that supports it in there,
such as "mstar,msc313-pmsleep" if this one is specific to msc313.

       Arnd