Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition
From: Ahmed S. Darwish
Date: Wed Jul 29 2020 - 10:38:24 EST
On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote:
> Manual repetition is boring and error prone.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> ---
...
> +/**
> + * typedef seqcount_LOCKNAME_t - sequence counter with spinlock associated
^ associated lock
> + * @seqcount: The real sequence counter
> + * @lock: Pointer to the associated spinlock
> + *
^ Pointer to the associated write serialization lock
> + * A plain sequence counter with external writer synchronization by a
> + * spinlock. The spinlock is associated to the sequence count in the
> + * static initializer or init function. This enables lockdep to validate
> + * that the write side critical section is properly serialized.
ditto, you forgot to change the associated spinlock language to generic
locks ;-)
Thanks,
--
Ahmed S. Darwish
Linutronix GmbH