Re: [PATCH 6/7] modules: return licensing information from find_symbol

[Jessica Yu]

+++ Christoph Hellwig [29/07/20 08:27 +0200]:
> Report the GPLONLY status through a new argument.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> include/linux/module.h |  2 +-
> kernel/module.c        | 16 +++++++++++-----
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index b79219eed83c56..c9bc3412ae4465 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -582,7 +582,7 @@ struct module *find_module(const char *name);
> struct symsearch {
> 	const struct kernel_symbol *start, *stop;
> 	const s32 *crcs;
> -	enum {
> +	enum mod_licence {
> 		NOT_GPL_ONLY,
> 		GPL_ONLY,
> 		WILL_BE_GPL_ONLY,
> diff --git a/kernel/module.c b/kernel/module.c
> index 54e853c7212f72..a907bc57d343f9 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -495,6 +495,7 @@ struct find_symbol_arg {
> 	struct module *owner;
> 	const s32 *crc;
> 	const struct kernel_symbol *sym;
> +	enum mod_licence licence;

Just a small nit. Most of module.c uses license rather than licence -
could we unify the spelling to remain consistent? Sigh, American vs.
British English.. :)