Re: [PATCH 2/7] modules: mark find_symbol static

From: Christoph Hellwig
Date: Wed Jul 29 2020 - 13:06:24 EST


On Wed, Jul 29, 2020 at 06:24:35PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 29, 2020 at 06:13:18PM +0200, Jessica Yu wrote:
> > +++ Christoph Hellwig [29/07/20 08:27 +0200]:
> > > find_symbol is only used in module.c.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> >
> > CCing the livepatching ML, as this may or may not impact its users.
> >
> > AFAIK, the out-of-tree kpatch module had used find_symbol() in the
> > past, I am not sure what its current status is. I suspect all of its
> > functionality has been migrated to upstream livepatch already.
>
> We still have symbol_get(), which is what I thought they were using.

And even if it didn't out of tree modules really don't matter.