Re: [PATCH net-next] hinic: add generating mailbox random index support

[luobin (L)]

On 2020/7/30 6:03, Jakub Kicinski wrote:
> On Wed, 29 Jul 2020 08:59:19 +0800 Luo bin wrote:
>> add support to generate mailbox random id for VF to ensure that
>> the mailbox message from VF is valid and PF should check whether
>> the cmd from VF is supported before passing it to hw.
> 
> This is hard to review. I don't see how the addition of
> hinic_mbox_check_cmd_valid() correlates to the random id 
> thing. Please split this into two or more patches making
> one logical change each.
> 
> .
> 
I'll split it into two patches. Thank you!